[Feat] Add s3 uploading from sdk #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e on all requests
jiyuu-jin
requested review from
BrettCleary,
flavioislima,
eliobricenov and
red-game-dev
BrettCleary
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
upload is working for me. I did not test download. can't find anything wrong with the code
maybe we should just remove the view the release at: line since the url will not work since it isn't a presigned url.
Upload progress for windows_amd64: 100
Successfully uploaded files to HyperPlay: https://gateway-b3.valist.io/hyperplaycd/irontest/v0.0.7
Publishing release... done
Confirming transaction 0xfef073aca4877f0eb4cef9b55d325cdc164e0aadba8fb176aa0e80fb823858ea... done
Successfully published hyperplaycd/irontest/v0.0.7!
view the release at:
https://gateway-b3.valist.io/hyperplaycd/irontest/v0.0.7
red-game-dev
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds s3 uploading to CLI via @valist/[email protected] implementation. Closes https://github.com/HyperPlay-Gaming/product-management/issues/446
Also closes #29 by skipping publishing and for the time being ignores the
keyslogic to be tested in another branch.Changes
axiosInstancewith cookie jar